Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove deleted tags from items #11309

Merged
merged 8 commits into from
Feb 15, 2023
Merged

Fix: Remove deleted tags from items #11309

merged 8 commits into from
Feb 15, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

  • None

Details

  • When a tag is deleted, it is removed from all files
  • When a tag is deleted/updated, the current page is refreshed to show changes
  • Added a null check to avoid NullReference when the user hits Esc after deleting a tag

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2
Copy link
Member

yaira2 commented Feb 15, 2023

It's removing it from the alternate data stream?

@ferrariofilippo
Copy link
Contributor Author

It's removing it from the alternate data stream?

I can't test this, I can't tag ADS. Whenever I apply a tag, refreshing the page will remove it

@yaira2
Copy link
Member

yaira2 commented Feb 15, 2023

I think we should wait for @gave92 to review this one.

@gave92
Copy link
Member

gave92 commented Feb 15, 2023

It's removing it from the alternate data stream?

Yeah it should

@gave92
Copy link
Member

gave92 commented Feb 15, 2023

Can't review anytime soon but looks good

@yaira2
Copy link
Member

yaira2 commented Feb 15, 2023

Can't review anytime soon but looks good

A looks good from you is enough for me 😂

yaira2
yaira2 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 15, 2023
@ferrariofilippo
Copy link
Contributor Author

LGTM

That was speedy!!!!

@yaira2 yaira2 merged commit 65834fc into files-community:main Feb 15, 2023
@ferrariofilippo ferrariofilippo deleted the Remove_Deleted_Tags_From_Files branch February 15, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gave92 gave92 gave92 left review comments

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferrariofilippo @yaira2 @gave92