Feature: Move open with to main menu when right clicking recent files

[hecksmosis]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Feature: Move "open with" to main menu when right clicking recent files #11298

Validation
How did you test these changes?

• Built and ran the app

[yaira2]

Is this working for you? I don't see the option and it's crashing as well.

[hecksmosis]

This works fine for me

[hecksmosis]

One of the few times CI doesn't spontaneously combust

[yaira2]

It's still not working for me, maybe someone else can test

[yaira2]

[hecksmosis]

I cannot reproduce this, don't know why this is happening

[hecksmosis]

Does this happen in main?

[yaira2]

main is fine

[yaira2]

@hishitetsu does this work for you?

[yaira2]

@hecksmosis in the meantime, can you share a screen recording of this in action?

[hishitetsu]

Sorry, I'm away from home and can't debug right now, but showOpenWithMenu: true was not specified in the other widgets and was causing the shell extension not to load, so I removed this option in #11270 .

[hecksmosis]

@hishitetsu I looked into this and it seems to work but only if you don't await it

[hecksmosis]

I'll send a screen recording

[hecksmosis]

f1fcd40d-7694-4ae8-b9c3-5314700cc655.webm

[hishitetsu]

I have identified the cause of the error.
Once #11325 is merged, the error should no longer occur.

The cause of the error was not whether there was await
The process flow here would be much the same with or without await, I think.

[yaira2]

It's working now but it looks like it's missing the placeholder that's supposed to show when the sub menu is loading. Also, there seems to be an issue in menu flyouts where the colored icons don't work so we might have to use a regular icon for now.

[hecksmosis]

It's working now but it looks like it's missing the placeholder that's supposed to show when the sub menu is loading. Also, there seems to be an issue in menu flyouts where the colored icons don't work so we might have to use a regular icon for now.

@yaira2 Do you mean a placeholder for the open with menu so it doesn't change size?

[yaira2]

Yes

[hecksmosis]

Ok, on it

[yaira2]

\uE17D

[hecksmosis]

Done

[yaira2]

LGTM