Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed context menu hang in recent files and other widgets #11301

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

hecksmosis
Copy link
Contributor

@hecksmosis hecksmosis commented Feb 14, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Fix: Fix context menu hanging in recent files and other widgets Fix: Fixedh context menu hang in recent files and other widgets Feb 14, 2023
@yaira2 yaira2 changed the title Fix: Fixedh context menu hang in recent files and other widgets Fix: Fixed context menu hang in recent files and other widgets Feb 14, 2023
@hecksmosis
Copy link
Contributor Author

hecksmosis commented Feb 14, 2023

The shell extensions don't load with these changes, I'm not convinced we need them though. I'm not running into any issues before this PR.

This uses the Loading menu options text we implemented and makes the context menu quicker to load

@yaira2
Copy link
Member

yaira2 commented Feb 14, 2023

It seems that I broke shell extensions on my device 😂

Will test after restarting

@hecksmosis
Copy link
Contributor Author

How did you do that lol

@yaira2
Copy link
Member

yaira2 commented Feb 14, 2023

Probably by spamming requests

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 14, 2023
@yaira2 yaira2 merged commit 1724d47 into files-community:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants