Feature: Disable show more options menu item until shell items are loaded

[hecksmosis]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Feature: Make context menu entry "Show more options" always visible #11236

Validation
How did you test these changes?

• Built and ran the app
• Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

[yaira2]

@hecksmosis can you fix the merge conflicts?

[hecksmosis]

Done

[ferrariofilippo]

Works totally fine for folders and files, but not for sidebar items. Also, you should implement this for widgets as well.

[hishitetsu]

One suggestion. Instead of simply disabling the menu while loading, how about changing the text to, for example, "Loading more options"? Simply disabling the menu may lead people to think that no additional options exist.

[yaira2]

One suggestion. Instead of simply disabling the menu while loading, how about changing the text to, for example, "Loading more options"? Simply disabling the menu may lead people to think that no additional options exist.

I agree

[hecksmosis]

Probably

[yaira2]

I added the loading label for BaseLayout and the sidebar but it still needs to be added for the widgets.

[yaira2]

@hishitetsu with the loading label, should we still disable the menu or is the loading label clear enough?

[hishitetsu]

I think it is still better to disable the menu.

[yaira2]

Widgets are done 👍

[yaira2]

One thing I noticed is that right clicking on Recycle Bin (from the Quick Access widget) or any file in the Recent Files widget causes the app to hang.

These are issues on main as well so LGTM

[hecksmosis]

Thanks for finishing it, had a pretty busy couple of days and couldn't work on this

[hishitetsu]

One thing I noticed is that right clicking on Recycle Bin (from the Quick Access widget) or any file in the Recent Files widget causes the app to hang.

I will submit a PR to fix these issues.