Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed the dialog may not be shown when undoing to delete items #11201

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Fix: Fixed the dialog may not be shown when undoing to delete items #11201

merged 1 commit into from
Feb 7, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@hishitetsu hishitetsu changed the title Additional fix to show a confirmation dialog Fix: Fixed the dialog may not be shown when undoing to delete items Feb 7, 2023
yaira2
yaira2 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 7, 2023
@yaira2 yaira2 merged commit 69de869 into files-community:main Feb 7, 2023
@hishitetsu hishitetsu deleted the AdditionalFix branch February 7, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: The dialog is not shown when undoing to delete items if the setting to show the dialog is off
2 participants
@hishitetsu @yaira2