Code Quality: Code cleanup and formatting

[0x5bfa]

Resolved / Related Issues

None

Change Overview

• Remove unnecessary line breaks
• Add line breaks for improving readability
• Use Lambda expression
• Use pattern matching
• Make C# files to end with '\r\n\0' (a line break and EOF)
• Simplify type name
• Simplify expression
• Capitalize the first word of each sentence in comment block.
• Use 'TODO' and 'NOTE', instead of 'todo', 'note', or anything else
• Use '//' for commenting our, instead of '/* */'
• Use if, else embedded statement when it is one line.
• Use switch expression

Unchanged files

• Dialogs/*
• Views/*
• Filesystem/*
• Helpers/*

Validation
How did you test these changes?

• Built and ran the app
• Tested the changes for accessibility

Screenshots (optional)

None

[hecksmosis]

Oh god, this is going to be fun to review

[ferrariofilippo]

Looks good, except for some cases

[0x5bfa]

@ferrariofilippo Done! Thank you for reviewing all of this, anyway.

[ferrariofilippo]

LGTM

[0x5bfa]

@yaira2 Can you review?

[0x5bfa]

@yaira2 Ready for re-review

BTW, What do you think of the order of Constructors, Fields, Properties, Methods? (wont include those changes in this)

My thought:

// Constructors

// Fields and Properties

// Methods

Some codes have properties which placed above class constructor. Should have an specification.

[yaira2]

@onein528 they might need to be cleaned up a bit if things are out of order, I wouldn't go do that throughout the whole codebase now since it'll take a long time to review but I'd recommend making the change to the file in question.

[0x5bfa]

Also, I have a suggestion of correcting of naming of some namespaces (wont include those changes in this)

Models:

'Views/SettingsPages/*.xaml(.cs)'        ->   'Views/Settings/*Page.xaml(.cs)'
'Views/Pages/Properties*.xaml(.cs)'      ->   'Views/Properties/*Page.xaml(.cs)'
'ViewModels/Properties/*Properties.cs'   ->   'ViewModels/Properties/*ViewModel.cs'
'ViewModels/SettingsViewModels/*.cs'     ->   'ViewModels/Settings/*.cs'
'ViewModels/Dialogs/*DialogViewModel.cs' ->   'ViewModels/Dialogs/*ViewModel.cs'


Examples:

'Views/SettingsPages/Appearance.xaml'   ->   'Views/Settings/AppearancePage.xaml'
'Views/Pages/PropertiesSecurity.xaml'   ->   'Views/Properties/SecurityPage.xaml'
'ViewModels/SettingsViewModels/AppearanceViewModel.cs' -> 'ViewModels/Settings/AppearanceViewModel.cs'
'ViewModels/Properties/SecurityProperties.cs'          -> 'ViewModels/Properties/SecurityViewModel.cs'
'ViewModels/Dialogs/CreateShortcutDialogViewModel.cs'  -> 'ViewModels/Dialogs/CreateShortcutViewModel.cs'

[yaira2]

@onein528 please let me know when you addressed a conversation and I'll resolve it from my side.

[0x5bfa]

@yaira2 DONE!

[0x5bfa]

OK, then. Thanks!

[yaira2]

Thank you