Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added support for changing groups direction #11154

Merged
merged 7 commits into from
Feb 9, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Details
Sorting and groups can now be selected in ascending or descending, respectively.

Screenshots
image

@yaira2
Copy link
Member

yaira2 commented Feb 8, 2023

Can you apply the same to the right click menu in the folder layouts?

@hishitetsu
Copy link
Member Author

I see, I'll try it later.

@hishitetsu
Copy link
Member Author

Done.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 9, 2023
@yaira2 yaira2 merged commit 50e8524 into files-community:main Feb 9, 2023
@hishitetsu hishitetsu deleted the GroupDirection branch February 9, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Groups should follow ascending/descending preference
2 participants