Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Sync pinned favorites with File Explorer #11120

Merged
merged 33 commits into from
Feb 2, 2023

Conversation

hecksmosis
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@hecksmosis
Copy link
Contributor Author

I am leaving this as a draft for now because there is room for a lot of improvement

@hecksmosis
Copy link
Contributor Author

Why is the check failing? It doesn't seem like the error is in my code

@yaira2
Copy link
Member

yaira2 commented Jan 30, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2 yaira2 changed the title Feature: Sync pinned sidebar items with file explorer Feature: Sync pinned sidebar items with File Explorer Jan 30, 2023
@yaira2
Copy link
Member

yaira2 commented Jan 30, 2023

I'll look into the CI failing

@yaira2
Copy link
Member

yaira2 commented Jan 30, 2023

@hecksmosis can you look into updating the pin/unpin to sidebar options when right clicking files and folders? Another thing to look into would be pinning recycle bin to the sidebar the first time the user launches Files.

@hecksmosis
Copy link
Contributor Author

The pin/unpin option should already Update, I'll look into the recycle bin thing tomorrow

@yaira2
Copy link
Member

yaira2 commented Jan 30, 2023

We also need to hide the options for reorganizing pinned items

@yaira2
Copy link
Member

yaira2 commented Jan 30, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2
Copy link
Member

yaira2 commented Jan 31, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jiejasonliu jiejasonliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to keep backwards compatibility with the existing (v2) PinnedItems.json
if that file exists, we should read them and pin the paths in the file

src/Files.App/Filesystem/PinnedItemsManager.cs Outdated Show resolved Hide resolved
src/Files.App/ServicesImplementation/PinnedItemsService.cs Outdated Show resolved Hide resolved
@hecksmosis
Copy link
Contributor Author

We also need to hide the options for reorganizing pinned items

I'm working on that

@hecksmosis
Copy link
Contributor Author

we want to keep backwards compatibility with the existing (v2) PinnedItems.json if that file exists, we should read them and pin the paths in the file

We should read it only once and pin the items, then delete the file as it will not be needed anymore

@hecksmosis hecksmosis marked this pull request as ready for review February 1, 2023 17:42
@yaira2 yaira2 requested a review from jiejasonliu February 1, 2023 17:58
@hecksmosis
Copy link
Contributor Author

CI is having a stroke

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Feb 2, 2023

Forgot about Recycle Bin, we should make sure to pin it the first time the user opens Files. Looks like this is covered, can you confirm?

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 2, 2023
@yaira2 yaira2 changed the title Feature: Sync pinned sidebar items with File Explorer Feature: Sync pinned favorites items with File Explorer Feb 2, 2023
@yaira2 yaira2 changed the title Feature: Sync pinned favorites items with File Explorer Feature: Sync pinned favorites with File Explorer Feb 2, 2023
@yaira2 yaira2 merged commit d31aab5 into files-community:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Sync pinned favorites with File Explorer
3 participants