-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Sync pinned favorites with File Explorer #11120
Feature: Sync pinned favorites with File Explorer #11120
Conversation
I am leaving this as a draft for now because there is room for a lot of improvement |
…/Files into pinned_items_explorer
Why is the check failing? It doesn't seem like the error is in my code |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I'll look into the CI failing |
@hecksmosis can you look into updating the pin/unpin to sidebar options when right clicking files and folders? Another thing to look into would be pinning recycle bin to the sidebar the first time the user launches Files. |
The pin/unpin option should already Update, I'll look into the recycle bin thing tomorrow |
We also need to hide the options for reorganizing pinned items |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to keep backwards compatibility with the existing (v2) PinnedItems.json
if that file exists, we should read them and pin the paths in the file
I'm working on that |
We should read it only once and pin the items, then delete the file as it will not be needed anymore |
Co-authored-by: yaira2 <[email protected]>
This reverts commit 10e9bb9.
CI is having a stroke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Forgot about Recycle Bin, we should make sure to pin it the first time the user opens Files. Looks like this is covered, can you confirm? |
Resolved / Related Issues
Items resolved / related issues by this PR.
Validation
How did you test these changes?