Feature: Use the tab key to select the next file while renaming

[ferrariofilippo]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Renaming a file using the arrow keys to navigate words in its name, will start selecting other files #9691
• Closes Enable the use of the Tab key to select next file while renaming #6675

Comments
There's a bug when you're at the beginning of a word and press Down Arrow. Nothing happens (also when you're at the end and press Up Arrow). Neither KeyDown nor PreviewKeyDown events are raised. GridView layout is not affected by the bug (but Tiles is)
I'll try to find a solution

Validation
How did you test these changes?

• Built and ran the app
• Tested the changes for accessibility

[QuaintMako]

LGTM and works on my machine.

I do have the issue where the down arrow doesn't do anything when at the start of the name as well. It'd be nice to fix it indeed.

[yaira2]

I think key + up/down should finish the rename and start renaming the item above/below it.
Actually, that's tab/shift tab

[ferrariofilippo]

Actually, that's tab/shift tab

Added. I had to use User32.dll to get Shift state because InputKeyboard.GetKeyStateForCurrentThread() caused some issues

[ferrariofilippo]

I do have the issue where the down arrow doesn't do anything when at the start of the name as well.

Ctrl+Up/Down arrow works. This may be a WinUI bug as it involves all textboxes (e.g. new file modal or properties window)

[yaira2]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ferrariofilippo]

I changed CommitRename from async void to async Task to avoid a bug where files/folders got duplicated.
I need to test this new feature further, but it seems to work.

Edit. Actually there are two bugs:

• when items are reordered rename doesn't work
• Shift+Tab when you change completely the name bugs the whole app

[ferrariofilippo]

There's a problem with ListViewBase.ContainerFromItem() which sometimes returns null even when the item exists. Once I figured out how to fix this, there should be no more bugs.
Edit. Happens only in DetailsLayout

[ferrariofilippo]

Everything should work now

[QuaintMako]

LGTM and works for me.

[hecksmosis]

LGTM

[yaira2]

@ferrariofilippo can you confirm this resolves #6675?

[ferrariofilippo]

Yes

[yaira2]

LGTM

[hecksmosis]

LGTM and seems to work

[yaira2]

I tested, it not only seems to work but it's a great improvement 😅