Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Moved menu items to left side of the settings dialog #11044

Merged
merged 7 commits into from
Jan 20, 2023
Merged

Feature: Moved menu items to left side of the settings dialog #11044

merged 7 commits into from
Jan 20, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jan 20, 2023 •
edited
Loading

Changes
Moved menu items to left side of the settings dialog

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
image

@yaira2 yaira2 requested a review from d2dyno1 January 20, 2023 16:50
hecksmosis
hecksmosis reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@hecksmosis hecksmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this issue with the folders tab. (It's scrolled all the way down but the warning isn't completely shown). Otherwise LGTM

image

@yaira2 yaira2 merged commit 985d66e into main Jan 20, 2023
@yaira2 yaira2 deleted the ya/Settings branch January 20, 2023 18:48
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecksmosis hecksmosis hecksmosis left review comments

@d2dyno1 d2dyno1 Awaiting requested review from d2dyno1

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaira2 @hecksmosis