Feature: Show error when a shortcut can't be created

[ferrariofilippo]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes Feature: "Can't create shortcut" modal #10987

Details

• Fixed a bug with shortcut's names created from modal (lines 82-86 CreateShortcutDialogViewModel.cs
• Added Can't create shortcut modal (I'm not sure if it should be displayed when File/Folder properties are edited)

Validation
How did you test these changes?

• Built and ran the app
• Tested the changes for accessibility

Screenshots (optional)

[ferrariofilippo]

I'm not sure if it should be displayed when File/Folder properties are edited

@yaira2 what about this?

[yaira2]

What do you mean by this?

[ferrariofilippo]

At the moment, when the user opens Properties of a shortcut, he/she can edit its attributes. When this happens, Files tries to update the shortcut. If this is placed in a protected directory (such as C:\) nothing happens and the user doesn't get any error.

What I'm asking is whether the Create on desktop modal should be displayed in this specific case.
If the answer is no, should we inform the user that he/she needs to run Files as admin to successfully edit the shortcut?

[yaira2]

I didn't realize it can be worked around if the user runs as administrator. We should update the message accordingly. Could try something like this "This action requires administrator privileges", "Please run Files as administrator to create this shortcut".

[ferrariofilippo]

I didn't realize it can be worked around if the user runs as administrator. We should update the message accordingly.

I think we should give the user the ability to create it on Desktop: if, for any reason , he can't run Files as admin, he should still be able to create that shortcut.

The modal might be like:
Title: This action requires administrator privileges
Message: Please, run Files as administrator or create it on Desktop

[ferrariofilippo]

I have to inform you that I have temporarily removed the binding from ItemDestinationPath. Now this property is being updated manually. I did this because I noticed that the Binding was not working anymore. In fact, if you try to create a shortcut from the modal (even in stable version), you'll see that it doesn't work (actually sometimes it works).

I know this is not optimal and I'll work to reintroduce the binding
Edit. Done

[yaira2]

LGTM