Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed crash that would sometimes occur when calculating folder sizes #11012

Merged

Conversation

jiejasonliu
Copy link
Contributor

Resolved / Related Issues

Details of Changes

  • Use ConcurrentDictionary to make contains-->add critical path atomic

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2
Copy link
Member

yaira2 commented Jan 18, 2023

@jiejasonliu can you add a code comment explaining this change for future reference?

@jiejasonliu
Copy link
Contributor Author

@jiejasonliu can you add a code comment explaining this change for future reference?

done!

…onliu/Files into 11006-add-provider-race-condition
@yaira2 yaira2 changed the title Fix: Fixed crash that can occur when calculating folder sizes Fix: Fixed crash that would sometimes occur when calculating folder sizes Jan 19, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 19, 2023
@yaira2 yaira2 merged commit dcf7e9d into files-community:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Calculate folder size sometimes crashes app
2 participants