Feature: Close column when selecting a file

[ferrariofilippo]

Resolved / Related Issues
Items resolved / related issues by this PR.

• Closes #10998

Details
Actual fix is at:

• FileList_ItemTapped(...) of ColumnViewBase.xaml.cs (lines 531-564)
• ColumnViewBase_ItemTapped(...) of ColumnViewBrowser.xaml.cs (lines 341-354)

Validation
How did you test these changes?

• Built and ran the app

[ferrariofilippo]

I think we should refactor Dispose() of ColumnViewBrowser.xaml.cs to avoid all unnecessary casts (I mean, we can cast each item only once as Frame instead of doing it four times)

[hecksmosis]

Apart from this I think it's ok

[hecksmosis]

I think we should refactor Dispose() of ColumnViewBrowser.xaml.cs to avoid all unnecessary casts (I mean, we can cast each item only once as Frame instead of doing it four times)

Yes, we probably should

[hecksmosis]

LGTM

[d2dyno1]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[yaira2]

@ferrariofilippo while it closes the column, it doesn't seem to clear the gray background on the folder. A second issue I noticed is that the column doesn't close if you select the file via keyboard shortcuts.

[ferrariofilippo]

@ferrariofilippo while it closes the column, it doesn't seem to clear the gray background on the folder. A second issue I noticed is that the column doesn't close if you select the file via keyboard shortcuts.

Done

[yaira2]

LGTM