Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Append app name to title #10900

Merged
merged 4 commits into from
Jan 2, 2023
Merged

Feature: Append app name to title #10900

merged 4 commits into from
Jan 2, 2023

Conversation

JaiganeshKumaran
Copy link
Contributor

@JaiganeshKumaran JaiganeshKumaran commented Jan 2, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

Instead of hardcoding the app name "Files", it takes the name from the SystemInformation class instead. In dev mode the title will be "Folder name - Files - Dev". I would recommend changing "Files - Dev" to "Files (Dev)" or simply "Files Dev" because it's cleaner.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jan 2, 2023
@yaira2 yaira2 merged commit 2038615 into files-community:main Jan 2, 2023
@yaira2 yaira2 changed the title Append app name to title Feature: Append app name to title Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Append app name to title
2 participants