Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Show shortcuts & hidden files in network folders #10872

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Feature: Show shortcuts & hidden files in network folders #10872

merged 1 commit into from
Dec 29, 2022

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Dec 29, 2022 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

@gave92 gave92 changed the title Show shortcuts in network folders Show shortcuts & hidden files in network folders Dec 29, 2022
@gave92
Copy link
Member Author

gave92 commented Dec 29, 2022 •
edited
Loading

Needs to be tested when installing the Package, IIRC it used to work only in Debug mode. Edit: Azure build appears OK.

@yaira2 yaira2 changed the title Show shortcuts & hidden files in network folders Feautre: Show shortcuts & hidden files in network folders Dec 29, 2022
@yaira2 yaira2 changed the title Feautre: Show shortcuts & hidden files in network folders Feature: Show shortcuts & hidden files in network folders Dec 29, 2022
yaira2
yaira2 reviewed Dec 29, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Dec 29, 2022
@yaira2 yaira2 merged commit 9ef96d1 into files-community:main Dec 29, 2022
@gave92 gave92 deleted the network_shortcuts branch December 29, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Support for showing shortcuts and hidden files in network drives
2 participants
@gave92 @yaira2