Feature: Removed accent color from non-selected items in the column layout #10818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
changed the title
yaira2
changed the title
|
Is the width of the item supposed to change? |
This reverts commit efe15be.
|
This was the only way I got this to work right now :( |
|
Is it possible to hide the selection indicator and build our own into the item template? |
|
It would be possible but a lot of work I think |
QuaintMako
reviewed
Dec 23, 2022
QuaintMako
reviewed
Dec 26, 2022
QuaintMako
previously approved these changes
Dec 26, 2022
|
@chingucoding is keyboard navigation still an issue? |
|
@yaira2 It seems to work now, but I would prefer if you would double check. |
QuaintMako
approved these changes
Dec 27, 2022
hecksmosis
approved these changes
Dec 27, 2022
yaira2
added
ready to merge
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Items resolved / related issues by this PR.
Validation
How did you test these changes?
Screenshots (optional)
