-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Implement the fundamental for rich progress #10814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very promising! Good work on what has been done already!
On a sidenote, I stopped noting it after a while, but all the files modified need to be reformated to be consistant with the existing codebase.
src/Files.App/Filesystem/FilesystemOperations/FileSystemProgress.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Filesystem/FilesystemOperations/FileSystemProgress.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Filesystem/FilesystemOperations/FileSystemProgress.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Filesystem/FilesystemOperations/FilesystemOperations.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Filesystem/FilesystemOperations/FilesystemOperations.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Filesystem/FilesystemOperations/FilesystemOperations.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Filesystem/FilesystemOperations/FilesystemOperations.cs
Outdated
Show resolved
Hide resolved
I have run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
Items resolved / related issues by this PR.
In this PR, I did two things:
IProgress<float>
andIProgress<FileSystemStatusCode>
toIProgress<FileSystemProgress>
FileSystemProgress
ofIProgress<FileSystemProgress>
to maintain progress information without needs of maintaining those information in the each implementation ofFileSystemOperation
This PR didn't change how we report the progress, with this fundamental we can improve them one by one in the future.
An example of zip extraction progress:
Validation
How did you test these changes?
Screenshots (optional)
Add screenshots here.