Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement the fundamental for rich progress #10814

Merged
merged 10 commits into from
Dec 25, 2022

Conversation

hez2010
Copy link
Member

@hez2010 hez2010 commented Dec 22, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

In this PR, I did two things:

  • Merge all IProgress<float> and IProgress<FileSystemStatusCode> to IProgress<FileSystemProgress>
  • Introduce a wrapper type FileSystemProgress of IProgress<FileSystemProgress> to maintain progress information without needs of maintaining those information in the each implementation of FileSystemOperation

This PR didn't change how we report the progress, with this fundamental we can improve them one by one in the future.

An example of zip extraction progress:

image

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very promising! Good work on what has been done already!
On a sidenote, I stopped noting it after a while, but all the files modified need to be reformated to be consistant with the existing codebase.

@hez2010
Copy link
Member Author

hez2010 commented Dec 24, 2022

I have run dotnet format to fix all indent related issues.
PTAL.

Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Dec 25, 2022
@yaira2 yaira2 merged commit dfd34b0 into files-community:main Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants