Code Quality: Refactored AdaptiveLayoutHelpers #10782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuaintMako
reviewed
Dec 23, 2022
|
Can you outline the changes that were made? |
|
@cinqmilleans can you resolve the merge conflicts? |
yaira2
changed the title
yaira2
requested review from
ferrariofilippo and
QuaintMako
and removed request for
ferrariofilippo
yaira2
added
needs - code review
and removed
changes requested
QuaintMako
approved these changes
Feb 13, 2023
yaira2
added
ready to merge
|
@cinqmilleans thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Refactor AdaptiveLayoutHelpers, which applies the layout according to the folder. The behavior has not changed.
This refactoring makes it easier to modify rules, which are not always suitable. For example, a video folder is not displayed in grid.
Validation
How did you test these changes?