Fix: Fixed issue where content on the search results page wasn't centered

[itayweb]

Resolved / Related Issues
Fixed #10549

Validation
How did you test these changes?

• Built and ran the app

[yaira2]

It's not supposed to be hidden, the issue is with the alignment 🤔

[itayweb]

It's not supposed to be hidden, the issue is with the alignment 🤔

The person who report this issue suggested 2 ways, either hiding it or align it, do you prefer I'll align it?

[yaira2]

It should be properly aligned

[itayweb]

Let me know if the code style need a fix

[QuaintMako]

LGTM aside the formatting, but someone with more experience on xaml files should review as well.

[QuaintMako]

Some issues on the formatting still. Maybe your git does some automatic formatting when committing?

[itayweb]

I tried again to fix the indent even though in my ide it doesn't seem to be a problem, let me know

[QuaintMako]

I tried again to fix the indent even though in my ide it doesn't seem to be a problem, let me know

Yup, seems something went bad formatting-wise with the last commits (+980 lines modified). I'll take a look to see if I can fix the indent myself.

[itayweb]

I tried again to fix the indent even though in my ide it doesn't seem to be a problem, let me know

Yup, seems something went bad formatting-wise with the last commits (+980 lines modified). I'll take a look to see if I can fix the indent myself.

Ok, thanks

[QuaintMako]

@itayweb that should do it formatting wise ;)

In case you did not know, you can chose if your tabs are made of spaces or actual tabs under visual studio. More info on Stack Overflow.

[QuaintMako]

The footer is now well centered, but maybe we could have the two messages to be centered relative to each other? Meaning having Search unindexed items. to be slightly more on the right. (Asking @yaira2 to be sure)

[yaira2]

The best way to solve this issue would be to move it out of the footer and put it under the "No items found" message.

[QuaintMako]

That should be it for this PR. The border controller has been removed and the button is now centered.

[yaira2]

@QuaintMako while you're at it, do you want to remove the . from "Search unindexed items"?

[yaira2]

LGTM