Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Crash with List View layout #14521

Closed
Mantej-Singh opened this issue Jan 22, 2024 · 27 comments · Fixed by #14533 or #14559
Closed

Bug: Crash with List View layout #14521

Mantej-Singh opened this issue Jan 22, 2024 · 27 comments · Fixed by #14533 or #14559
Labels
crash Bug reports involving a crash help wanted Extra attention is needed

Comments

@Mantej-Singh
Copy link

Mantej-Singh commented Jan 22, 2024

Description

The app crashes when I use the List View layout on the latest preview version 3.1.4.0, but only if the window is maximized. My folder contains more than 1000 files.

Steps To Reproduce

  1. open a folder with multiple files
  2. change the layout to List
  3. make sure app window is maximized

Requirements

when you maximize the window with list view on

Files Version

3.1.4.0

Windows Version

10.0.23619.1000

Log File

debug.log

@Josh65-2201
Copy link
Member

Thanks for the report, I've added this to the project board.

@Josh65-2201 Josh65-2201 added the crash Bug reports involving a crash label Jan 22, 2024
@Josh65-2201 Josh65-2201 changed the title Crash with List View layout on preview version 3.1.4.0 Bug: Crash with List View layout Jan 22, 2024
@yaira2
Copy link
Member

yaira2 commented Jan 22, 2024

Does the layout change to list or does it crash right away?

@yaira2 yaira2 added the needs - additional info Needs more information from the reporter label Jan 22, 2024
@Mantej-Singh
Copy link
Author

It does change to list view.
Once the list view is applied, it crashed after 2-3 seconds

@yaira2
Copy link
Member

yaira2 commented Jan 22, 2024

Unfortunately the log file doesn't contain any info about the crash. Can you upload a screen recording?

@Mantej-Singh
Copy link
Author

Yeah I figured, it was only 10kb.
Let me work on a screen recording

@Mantej-Singh
Copy link
Author

Would you like a crash dump?
I found it on my C:\Users\Mark-VI\AppData\Local\CrashDumps folder

@Mantej-Singh
Copy link
Author

@yaira2
here is video

Bug.14521.mp4

@yaira2
Copy link
Member

yaira2 commented Jan 22, 2024

Interesting, does it also crash if you maximize the window before switching to List View?

@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Jan 22, 2024
@Mantej-Singh
Copy link
Author

yes.

@yaira2 yaira2 removed the needs - additional info Needs more information from the reporter label Jan 22, 2024
@Mantej-Singh
Copy link
Author

Mantej-Singh commented Jan 22, 2024

It only happens to folders with a lot of files
Eg: In the above video, if i can go to my Music folder it will if crash.

@yaira2
Copy link
Member

yaira2 commented Jan 22, 2024

I can repro this as well

@Mantej-Singh
Copy link
Author

I appreciate you working on this.
Did you figure out what the issue is?

@yaira2
Copy link
Member

yaira2 commented Jan 23, 2024

A big thank you to @marcelwgn for fixing this issue.

@Mantej-Singh
Copy link
Author

Thanks @marcelwgn

@Mantej-Singh
Copy link
Author

@yaira2
When will the fix be available in the preview version?

@Josh65-2201
Copy link
Member

It's in 3.1.6 right now

@Mantej-Singh
Copy link
Author

thanks, updating it now.
image

@Mantej-Singh
Copy link
Author

Mantej-Singh commented Jan 23, 2024

ahh guys, @yaira2 @Josh65-2201
It's crashing again. The whole app is freezing I am unable to access any file

App Version: 3.1.6.0
Windows version: 10.0.23619.1000

@yaira2 yaira2 reopened this Jan 23, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🆕 New in Files task board Jan 23, 2024
@yaira2 yaira2 added the help wanted Extra attention is needed label Jan 24, 2024
@yaira2 yaira2 pinned this issue Jan 24, 2024
@ElQuia345
Copy link

ElQuia345 commented Jan 26, 2024

It is happening to me on 3.1.7.0 Windows 10.0.19045.3996, without changing windows size, I select list view. If folder has 95 items nothing happens. If it has 330 items it crashes when I change in to it. I was using stable version, missing a lot list view, I use it as default in all my file managers, change to thumbnails on images or videos only. I saw testing version had list view I installed it. And bang, crash.
Edit 2: It does not crash with less than 100 folders/files in open view, it always does with more.
System is a Ryzen 7 5800G NVME SSD, 32 GB RAM, dual monitor

@Mantej-Singh
Copy link
Author

I tested @hishitetsu patch and it is working fine.
image

@ElQuia345
Copy link

I tested @hishitetsu patch and it is working fine. image

Is the patch downloadable and does it work on 3.1.7.0?

@Josh65-2201
Copy link
Member

No, It's not available yet.

@ElQuia345
Copy link

No, It's not available yet.

OK, will wait... the list feature was one of the few things missing that stopped me from going default with Files..
BTW, it WOULD be nice if when in two pane mode, the divisor line between panes was more visible, thicker, aka some two pane file managers.... as it is it gets kind of confusing, not a problem, just hard on eyes
LOVE the work. Thanks

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Jan 28, 2024
@yaira2
Copy link
Member

yaira2 commented Jan 28, 2024

Thanks for the feedback, this issue will be resolved in the next release.

@Mantej-Singh
Copy link
Author

Crashing on 3.1.7.0.
Is the fix pushed to 3.1.7.0 build?

image

@hishitetsu
Copy link
Member

No, you will have to wait until the next preview release (probably 3.1.8.0).

@Mantej-Singh
Copy link
Author

Understandable, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Bug reports involving a crash help wanted Extra attention is needed
Projects
Archived in project
5 participants