This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Allow test L1 IP addresses #58
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: The orchestrator url is
https://orchestrator.strn.pl
, the discovery url ishttps://orchestrator.strn.pl/nodes/nearby
. Therefore I think either we rename this variables todefaultL1DiscoveryUrl
or change the env var to not need the path suffix. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the discovery URL for the test net? Is it a different hostname with the same path, e.g. something like
https://orchestrator.test.strn.pl/nodes/nearby
? In that case providing a host name only may work.In general, I feel it's better to avoid magic in configuration. If we need to configure discovery URL, then the config option should specify the full URL.
This way it's much easier to mock the discovery service for testing, as the mock does not need to replicate the path structure of the real one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The orchestrator test net url is https://orchestrator.saturn-test.network/nodes/nearby (from https://github.com/filecoin-saturn/orchestrator#readme)