Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Add sign and notarize macOS x86_64 #35 #53

Merged
merged 66 commits into from
Sep 27, 2022
Merged

Conversation

juliangruber
Copy link
Contributor

@juliangruber juliangruber commented Aug 23, 2022

For #35

@juliangruber juliangruber added the enhancement New feature or request label Aug 23, 2022
bajtos
bajtos previously approved these changes Aug 30, 2022
Copy link
Contributor

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand all details, but the changes look reasonable to me 👍🏻

Copy link
Contributor Author

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bajtos annotated the changes ftr

.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
@juliangruber
Copy link
Contributor Author

Ok the code signing tool used (gon) doesn't support signing arm yet: mitchellh/gon#40

@juliangruber
Copy link
Contributor Author

at least signing the x86_64 works so far

@juliangruber
Copy link
Contributor Author

@bajtos what do you think we should do strategy wise? Wait until gon supports arm64 (or help implement it), or figure out the manual route here?

.gon.arm64.hcl Outdated Show resolved Hide resolved
@juliangruber juliangruber marked this pull request as ready for review September 21, 2022 15:46
@juliangruber
Copy link
Contributor Author

@bajtos you can check out the release artifacts here: https://github.com/filecoin-saturn/L2-node/actions/runs/3099194083

@bajtos
Copy link
Contributor

bajtos commented Sep 22, 2022

the arm64 signing isn't supported by gon yet :(

Hmm, that's a bummer! 😫

what do you think we should do strategy wise? Wait until gon supports arm64 (or help implement it), or figure out the manual route here?

I don't know how much work is required to sign & notarise an app manually. I suspect it will be a non-trivial thing.

I think it's better to work with gon maintainers to help everybody understand what changes are need to make gon work for darwin/arm64.

Maybe it's just a matter of configuring their GoReleaser to build both Intel and Arm64 versions?

https://github.com/mitchellh/gon/blob/master/.goreleaser.yml

I think just figuring out the action plan to get arm64 support will be a great contribution and it can enable other community members to do the actual work.

@juliangruber
Copy link
Contributor Author

I think it's better to work with gon maintainers to help everybody understand what changes are need to make gon work for darwin/arm64.

I reached out here: mitchellh/gon#40 (comment)

I also cleaned up the branch, could you review please? 🙏

bajtos
bajtos previously approved these changes Sep 27, 2022
Copy link
Contributor

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion to consider.

.gon.hcl Outdated Show resolved Hide resolved
Co-authored-by: Miroslav Bajtoš <[email protected]>
@juliangruber juliangruber changed the title Add sign and notarize for macOS. Closes #35 Add sign and notarize for macOS #35 Sep 27, 2022
@juliangruber juliangruber changed the title Add sign and notarize for macOS #35 Add sign and notarize macOS x86_64 #35 Sep 27, 2022
@juliangruber juliangruber merged commit fe72d8e into main Sep 27, 2022
@juliangruber juliangruber deleted the add/sign-and-notarize branch September 27, 2022 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants