This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Add empty webui + rework port config #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rework the HTTP server to serve a dummy HTML page at `/webui` path - Rework port configuration to use port number 5500 by default and allow the caller to change the port number via `PORT` environment variable. Signed-off-by: Miroslav Bajtoš <[email protected]>
|
@aarshkshah1992 please review. I slightly tweaked your initial web server to get it closer to what I envision for the Station Electron app. |
bajtos
commented
May 25, 2022
| @@ -35,27 +42,16 @@ func main() { | |||
| }() | |||
|
|
|||
| time.Sleep(1 * time.Second) | |||
There was a problem hiding this comment.
@aarshkshah1992 Why is this sleep needed? Are we trying to wait for the HTTP server to start? I believe the listener nl is already accepting new TCP connections by now.
There was a problem hiding this comment.
You are right, we can remove this.
There was a problem hiding this comment.
Cool, I opened a follow-up PR:
#16
@aarshkshah1992 PTAL
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/webuipaththe caller to change the port number via
PORTenvironment variable.