Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Fix binary name for macOS releases #103

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix binary name for macOS releases #103

merged 1 commit into from
Apr 26, 2023

Conversation

bajtos
Copy link
Contributor

@bajtos bajtos commented Apr 26, 2023

Before this change, macOS archive used L2-node as the binary name, while all other platforms used saturn-L2-node instead.

This commit fixes the problem by making macOS consistent with other platforms.

@bajtos
Copy link
Contributor Author

bajtos commented Apr 26, 2023

We need this for filecoin-station/core#110 to fix a regression introduced by filecoin-station/core#109

Before this change, macOS archive used `L2-node` as the binary name,
while all other platforms used `saturn-L2-node` instead.

This commit fixes the problem by making macOS consistent with other
platforms.

Signed-off-by: Miroslav Bajtoš <[email protected]>
@bajtos bajtos changed the title Set binary name for macOS releases Fix binary name for macOS releases Apr 26, 2023
@bajtos
Copy link
Contributor Author

bajtos commented Apr 26, 2023

All is good now 👍🏻

https://github.com/filecoin-saturn/L2-node/actions/runs/4808458536/jobs/8558463637#step:9:43

    • building                             binary=dist/saturn_linux_386/saturn-L2-node
    • building                             binary=dist/saturn_linux_arm64/saturn-L2-node
    • building                             binary=dist/saturn_linux_amd64_v1/saturn-L2-node
    • building                             binary=dist/saturn_windows_amd64_v1/saturn-L2-node.exe
    • building                             binary=dist/saturn_windows_386/saturn-L2-node.exe
    • building                             binary=dist/macos-x86-64_darwin_amd64_v1/saturn-L2-node

@juliangruber PTAL, so that I can land this PR and publish a new release.

Copy link
Contributor

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@bajtos bajtos merged commit f5c5ca0 into main Apr 26, 2023
@bajtos bajtos deleted the fix-goreleaser-config branch April 26, 2023 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants