Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add network blockstore #5556

Merged
merged 2 commits into from
Dec 12, 2022
Merged

feat: add network blockstore #5556

merged 2 commits into from
Dec 12, 2022

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Dec 12, 2022

关联的Issues (Related Issues)

#5550

filecoin-project/lotus#9565

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题(接口, 配置,数据,灰度),如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode self-assigned this Dec 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #5556 (adae88e) into master (35df6cd) will increase coverage by 0%.
The diff coverage is 32%.

❗ Current head adae88e differs from pull request most recent head 1900176. Consider uploading reports for the commit 1900176 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #5556    +/-   ##
=======================================
  Coverage      25%     25%            
=======================================
  Files         609     613     +4     
  Lines       68623   69428   +805     
=======================================
+ Hits        17745   18051   +306     
- Misses      48612   48998   +386     
- Partials     2266    2379   +113     

Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diwufeiwen
Copy link
Contributor

#5550 应该还涉及venus-market中的改动

@simlecode
Copy link
Collaborator Author

是的,还有检索相关的

@simlecode simlecode merged commit 59a0c52 into master Dec 12, 2022
@simlecode simlecode deleted the feat/network-blockstore branch December 12, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants