Patch/ticket in nulls #453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tickets in tipsets with multiple losing tix
ZenGround0
reviewed
Aug 22, 2019
| @@ -352,7 +433,7 @@ potentially long chain scans would be required to compute a given block's weight | |||
|
|
|||
| ### Selecting between TipSets with equal weight | |||
|
|
|||
| When selecting between TipSets of equal weight, a miner chooses the one with the smallest min ticket (by bytewise comparison). | |||
| When selecting between TipSets of equal weight, a miner chooses the one with the smallest min ticket. | |||
There was a problem hiding this comment.
My reading of the above discussion is that tickets are comparable against tickets but I don't know how to compare ticket arrays with each other. Comparing ticket arrays is the thing we really want for 1) tie breaking, 2) consistent message application order. It is the thing we should include in the spec.
Right now I'm imagining we just take the first ticket of the array and compare.
There was a problem hiding this comment.
Reading above I'm actually guessing its the final ticket, not the first. But let's make sure to make that clear.
There was a problem hiding this comment.
Understood. Yes! Thanks
|
outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three big changes: