Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature Aggregation #210

Closed
wants to merge 14 commits into from
Closed

Signature Aggregation #210

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
79cfdc4
init changes to signature spec to comply with Issue #123
bvohaska Mar 22, 2019
f343b58
added minor changes requested by @whyareusleeping. Added exposition o…
bvohaska Mar 25, 2019
c397188
changed input parameters for Signature.Verify. Changed fields in Sign…
bvohaska Mar 26, 2019
1b4a64d
incremental update. Added VerifyAggregate to Signature interface. Cha…
bvohaska Mar 27, 2019
943183c
added ECDSA exposition. Added information for BLS signature recovery.
bvohaska Mar 27, 2019
9cd1b6a
added comments to actors and mining specs that state that ValidateSig…
bvohaska Mar 27, 2019
8f7eed4
added minor cosmetic changes: removed go-filecoin references, changed…
bvohaska Apr 1, 2019
3b0cc40
updated signature.md to include corrections from dignifiedinquire
bvohaska Apr 2, 2019
e652297
formatting updates. Added references requested in the PR.
bvohaska Apr 9, 2019
81b7c16
reworked SignedMessage description. Added marshall and Unmarshall met…
bvohaska Apr 9, 2019
ee3d49b
moved Tickets definition to data-structures.md; redefined SignedMessa…
bvohaska Apr 17, 2019
8e71e61
reworked methods in the Signature interface to better reflect coommen…
bvohaska Apr 17, 2019
27fc4b8
added message breakdown in the Block struct
bvohaska Apr 17, 2019
202ef41
added description of BLS aggregation for block creation
bvohaska Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion actors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ Parameters:

Return: None

All references to `VaidateSignature` must implement the `Signature` interface found [here](https://github.com/filecoin-project/specs/blob/master/signatures.md).

```go
func SlashConsensusFault(block1, block2 BlockHeader) {
if block1.Height != block2.Height {
Expand Down Expand Up @@ -440,7 +442,7 @@ Note: this is unlikely to ever be called on-chain, and will be a very large amou

### ArbitrateDeal

This may be called by anyone to penalize a miner for dropping the data of a deal they committed to before the deal expires. Note: in order to call this, the caller must have the signed deal between the client and the miner in question, this would require out of band communication of this information from the client to acquire.
This may be called by anyone to penalize a miner for dropping the data of a deal they committed to before the deal expires. Note: in order to call this, the caller must have the signed deal between the client and the miner in question, this would require out of band communication of this information from the client to acquire. All references to `VaidateSignature` must implement the `Signature` interface found [here](https://github.com/filecoin-project/specs/blob/master/signatures.md).

Parameters:
- deal Deal
Expand Down
2 changes: 1 addition & 1 deletion mining.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ Chain selection is a crucial component of how the Filecoin blockchain works. Eve

### Block Validation

The block structure and serialization is detailed in [the datastructures spec](data-structures.md#block). Check there for details on fields and types.
The block structure and serialization is detailed in [the datastructures spec](data-structures.md#block). Check there for details on fields and types. All references to `VaidateSignature` must implement the `Signature` interface found [here](https://github.com/filecoin-project/specs/blob/master/signatures.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition is confusing. Why not just say that signature validation is covered in detail in the signature spec?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good point. I've been mulling over how to best represent that ValidateSignature must use the verification method in signatures.md. The current phrasing is confusing b/c it should read: "Block implements the Signature interface" and ValidateSignature --> Block.Verify(SignedMessage_Block, PublicKey). in this case, the internal block messages would be represented as a single value (hashed), SignatureBytes would be the actual signature of the message and Address would be the address of the block proposer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need a place that implements verification of the aggregated signatures, e.g. a method like VerfiyAggregates([]Message, SignatureBytes) bool for use inside the block validation.


In order to validate a block coming in from the network at round `N` was well mined a miner must do the following:

Expand Down
Loading