Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommitSector accepts SectorId and CommRStar #122

Closed
wants to merge 1 commit into from
Closed

CommitSector accepts SectorId and CommRStar #122

wants to merge 1 commit into from

Conversation

laser
Copy link
Contributor

@laser laser commented Jan 29, 2019

  • sector id is an input to the PoRep-generating operation
  • fix typo which omitted CommRStar from CommitSector parameter-list

@laser
CommitSector accepts SectorId and CommRStar
051bb7b 
- sector id is an input to the PoRep-generating operation
- fix typo which omitted CommRStar from CommitSector parameter-list
@laser laser mentioned this pull request Jan 29, 2019
Closed
@whyrusleeping
Copy link
Member

@laser sorry, made a merge conflict for you

@pooja
Copy link
Contributor

pooja commented Apr 17, 2019

@whyrusleeping Is this blocked or can it be merged?

@laser
Copy link
Contributor Author

laser commented Apr 17, 2019

It can be closed. All three commitment-parameters were merged into Commitment.

@laser laser closed this Apr 17, 2019
@pooja
Copy link
Contributor

pooja commented Apr 17, 2019

Thanks @laser

@nicola nicola deleted the 121-sector-id-as-input-to-commit-sector branch November 29, 2019 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laser @whyrusleeping @pooja