Supersnaps (Snarkpack for SnapDeals) with tests #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
reviewed
Oct 25, 2023
cryptonemo
force-pushed
the
supersnaps
branch
from
7563ddf
to
a5ae3eb
Compare
vmx
reviewed
Oct 30, 2023
vmx
reviewed
Oct 31, 2023
cryptonemo
force-pushed
the
supersnaps
branch
from
c207e75
to
d765dff
Compare
cryptonemo
force-pushed
the
supersnaps
branch
2 times, most recently
from
49e1bfc
to
90ddf6b
Compare
feat: re-factor some tests
cryptonemo
force-pushed
the
supersnaps
branch
from
90ddf6b
to
311d566
Compare
vmx
previously approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Looks good to me, but I certainly also want to see an approval from @DrPeterVanNostrand.
DrPeterVanNostrand
previously approved these changes
Dec 12, 2023
cryptonemo
dismissed stale reviews from DrPeterVanNostrand and vmx
via
3d481e4
DrPeterVanNostrand
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.