Updated deps #1615
Updated deps #1615
Conversation
…sions * feat: extend aggregation tests to ensure version incompatibility * feat: update bellperson and neptune to latest * feat: update CI nightly
cryptonemo
requested review from
dignifiedquire,
DrPeterVanNostrand and
vmx
as code owners
Cargo.toml
Outdated
|
|
||
| [patch.crates-io] | ||
| bellperson = { git = "https://github.com/filecoin-project/bellperson", branch = "forward-port-updates" } | ||
| neptune = { git = "https://github.com/filecoin-project/neptune", branch = "updated-deps" } |
There was a problem hiding this comment.
FIXME: Requires filecoin-project/bellperson#274 and argumentcomputer/neptune#150 followed by crate releases
There was a problem hiding this comment.
Many dependencies switched from ^ (which is the implicit default)to~. I'd prefer if we would keep ^` (resp. the implicit default). This is what semver is about. This way one wouldn't need to update the Cargo.toml as often.
Though I also don't have a super strong opinion about it and could live with manually updating things more often.
|
I'm up for trying this change, as not manually updating has bitten us more than once and it's caused me to think the cargo/crate/semver system is broken. Unfortunately, this small change won't fix it for all of the external deps, which have been broken by toolchain issues recently (for example), but it shouldn't hurt either. |
No description provided.