-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade to latest versions #1504
Conversation
The latest versions of the gpu dependencies contain support for CUDA. Therefore the `gpu` feature is split into `cuda` and `opencl`. By default only `opencl` is enabled. BREAKING CHANGE: The `gpu` feature is replaced by the `opencl` feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update the circle ci config to test both features please?
I thought I concentrate on OpenCL first as this is what we want to ship. Next step would then be CUDA with proper testing, updates of the README etc. So I would make the CUDA stuff a separate PR. Though perhaps it just works, so let's try it out. |
I've added a new test run for the |
@cryptonemo I leave the merge to you (I couldn't merge anyway due to "Required statuses must pass before merging"). |
I also don't recall where the required CI tests are checked/unchecked. I'm ok merging this, but want to be sure that CI will not be broken on master from this point forward. Any insight? |
Oh wait, I think I found it: https://github.com/filecoin-project/rust-fil-proofs/settings/branch_protection_rules/2848255 If this seem correct (where I can uncheck ones after merging), I'll proceed. Sanity check? |
the required tests changed with the |
I see, I've removed all of the old ones then. |
The latest versions of the gpu dependencies contain support for CUDA. Therefore
the
gpu
feature is split intocuda
andopencl
. By default onlyopencl
isenabled.
BREAKING CHANGE: The
gpu
feature is replaced by theopencl
feature.