fix: switch to yastl thread pool #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,6 +60,8 @@ lazy_static! { | |||
| /// It might be possible to relax this constraint, but in that case, only one builder | |||
| /// should actually be active at any given time, so the mutex should still be used. | |||
| static ref GPU_LOCK: Mutex<()> = Mutex::new(()); | |||
|
|
|||
| static ref THREAD_POOL: Pool = Pool::new(num_cpus::get()); | |||
There was a problem hiding this comment.
Here you are using num_cpus::get()whereas in bellperson you are using an env-var BELLMAN_NUM_CPUS to get the number of CPU's, should these two values always agree?
There was a problem hiding this comment.
No, I don't think so. The bellman var is bellman specific, and that's ok. If we had a proofs specific one, it might be different, but proofs generally targets max parallelism from the available cores.
cryptonemo
force-pushed
the
feat-threadpool
branch
from
3983d18
to
b80dede
Compare
This avoids all deadlocks as so far observed. Also uses a more flexible channel for sync
cryptonemo
force-pushed
the
feat-threadpool
branch
from
b80dede
to
3a1b7d2
Compare
cryptonemo
approved these changes
Aug 10, 2021
|
Final testing is happening, but in fact, I have a machine that reliably hangs now during tests without this fix. Performance has so far been measured to be 'about the same' to 'a hair faster'. When my last test completes, assuming perf hasn't degraded after the rebases to latest, I'll merge. |
dignifiedquire
added a commit
that referenced
this pull request
Aug 26, 2021
This reverts commit bde2c88.
dignifiedquire
added a commit
that referenced
this pull request
Aug 30, 2021
This reverts commit bde2c88.
dignifiedquire
added a commit
that referenced
this pull request
Aug 30, 2021
This reverts commit bde2c88.
cryptonemo
pushed a commit
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids all deadlocks as so far observed. Also uses a more flexible channel
for sync
Depends on filecoin-project/bellperson#204