feat: raise soft fdlimit to max at runtime (os x/linux) #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptonemo
requested review from
dignifiedquire and
porcuquine
as code owners
|
I believe this is related to #1327. In that issue, an open file descriptor limit is hit write persisting the tree data in parallel batches (or at least that's the case that has been reproduced resulting in the same error reported). This PR does 2 things: 1) It logs what the max available fd limit is, which is commonly mis-configured on users' systems, and 2) It explicitly raises the fd descriptor limit from the soft limit to the max. |
| @@ -997,6 +997,9 @@ impl<'a, Tree: 'static + MerkleTreeTrait, G: 'static + Hasher> StackedDrg<'a, Tr | |||
| LabelsCache::<Tree>::new(&label_configs).context("failed to create labels cache")?; | |||
| let configs = split_config(tree_c_config.clone(), tree_count)?; | |||
|
|
|||
| let res = fdlimit::raise_fd_limit().expect("Failed to raise the fd limit"); | |||
There was a problem hiding this comment.
This should not panic, but simply print a warning
feat: add tool that shows max available open files
cryptonemo
force-pushed
the
raise-fdlimit
branch
from
9555051
to
f70d404
Compare
dignifiedquire
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add tool that shows max available open files