Make pieces::Stack methods private. #1202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pieces::Stack
struct is only used in the implementation ofcompute_comm_d
, and accurate usage of its helper methods is required for correctness. For example,peek()
andpeek2
must not be called when the stack is not large enough. This correctness is guaranteed by usage ofStack
as a helper data structure withincompute_comm_d
as written, but there is no reason to expose these methods to callers who might misuse them. Put differently, correctness of theStack
data structure depends on these methods being private. This allows a reader to determine — by only inspecting thepieces
module — that these methods are never called incorrectly.