Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test if permutation is valid #1193 #1195

Merged
merged 1 commit into from
Jul 2, 2020
Merged

test: test if permutation is valid #1193 #1195

merged 1 commit into from
Jul 2, 2020

Conversation

keyvank
Copy link
Contributor

@keyvank keyvank commented Jul 1, 2020

Resolves #1193

@keyvank keyvank requested a review from porcuquine July 1, 2020 11:45
porcuquine
porcuquine reviewed Jul 1, 2020
View reviewed changes
Copy link
Collaborator

@porcuquine porcuquine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @nicola Would you please approve if you accept this as a resolution to #1193?

@nicola
Copy link
Contributor

nicola commented Jul 2, 2020

Code is correct, I won't be able to run it at the moment, merge if test pass (I assume CI runs the test?)

@porcuquine
Copy link
Collaborator

@keyvank Can you rebase?

@porcuquine porcuquine merged commit 00a8d95 into master Jul 2, 2020
@porcuquine porcuquine deleted the feistel-test branch July 2, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@porcuquine porcuquine porcuquine approved these changes

@cryptonemo cryptonemo Awaiting requested review from cryptonemo cryptonemo is a code owner

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test feistel implementation is a valid permutation
3 participants
@keyvank @nicola @porcuquine