fix: run on stable rust and update CI #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptonemo
previously approved these changes
Jun 3, 2020
|
@cryptonemo I think the FFI is happy, I removed those targets with this commit, so it can well be that those are kind of screwed up. If you think it's ready to be merged, could you please merge this one together with filecoin-project/rust-filecoin-proofs-api#20 and filecoin-project/filecoin-ffi#102, you know better than I what other things are going on and when is a good time to do the merge. |
The CI is now testing only the version that is specified in the `rust_toolchain` file. Previously that version plus stable was tested, but now as we are on stable, there is not need to run tests twice. The `--all` flag for `cargo` is deprecated, instead one should use `--workspace`. This commit also makes this adjustment.
cryptonemo
force-pushed
the
rust-stable-143
branch
from
e2b8621
to
319bc2b
Compare
porcuquine
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI is now testing only the version that is specified in the
rust_toolchainfile.Previously that version plus stable was tested, but now as we are on stable, there is
not need to run tests twice.
The
--allflag forcargois deprecated, instead one should use--workspace. Thiscommit also makes this adjustment.