refactor(storage-proofs): fix clippy warnings #1147

clippy emits error: error: this `else { if .. }` block can be collapsed Do what clippy suggests, collapse the else if block.

In test module we bring into scope `rand` but do not use it (thread_rng() is called using a qualified path). Remove the unused `rand` import.

As suggested by clippy we can use `iter()` instead of `into_iter() in a bunch of places.`

Clippy emits a bunch of warnings of type: warning: useless use of `vec!` And suggests that we can use a slice direcly help: you can use a slice directly: `&[None; 256]` Do as clippy suggests; use slices directly.

Found with clippy; we are using a for loop but the current lint level requires us to use an iterator. As suggested; use an iterator instead of the for loop.

Found with clippy; `bytes_to_fr` does not need a mutable reference.

Remove unnecessary usage of `into()`, found by clippy.

Remove unnecessary usage of `clone()`, found by clippy.

Clippy emits error: error: you don't need to add `&` to all patterns Along with the suggestion to dereference the expression instead of prefixing all patters with `&`. Do as suggested by clippy and dereference the expressions.

Clippy emits two errors of type: error: You are using an explicit closure for copying elements Along with the suggestion to us `copied` instead. Do as clippy suggests.

The function `pedersen_md_circuit_benchmark` is defined but not used, it appears that this function should be added to the `criterion_group` marcro call. Found by clippy.

`tempfile` is brought into scope but is never used. Found by clippy.

Plain old `return;` is idiomatic Rust these days, found by clippy.

We declare a local buffer and never use it. Found by clippy.

Clippy emits error: error: long literal lacking separators Use separators, as suggested by clippy, to assist reading.

Clippy emits warning: warning: passing a unit value to a function The argument in question is not actually used by the function `circuit` (if I've jumped to the correct definition). We can safely pass in unit `()` instead. Does this result in any loss of meaning?

Clippy emits warning warning: digits grouped inconsistently by underscores Add an underscore, as suggested, in order to be consistent.

Import is unused; found by clippy.

Clippy emits error: error: identical conversion Remove, as suggested by clippy, unnecessary `into_iter()`.

Clippy emits error: error: the loop variable `i` is used to index `val` Use an iterator, as suggested, to loop over the arrays of bytes. Use combinators `skip` and `take` as needed.

Clippy emits error: error: casting integer literal to `f64` is unnecessary Use `32_f64` as suggested instead of casting to an `f64`.

Clippy emits error: error: the operation is ineffective. Consider reducing it to `127` This is caused because we use `1 * 127` in order to be consistent with other usages i.e., `2 * 127` and `8 * 127`. Clippy is wrong in this instance, the ineffective operation makes the code easier to read. Instruct clippy to allow this lint.

Clippy emits warning/error; useless use of `vec!` Do as suggested by clippy and use a slice directly.

Clippy emits warning: warning: redundant clone Do as clippy suggests; remove redundant calls to `clone()`

Clippy emits error: error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type This error is caused by code that is mildly convoluted by the fact that the only method on `TempDir` that returns a `PathBuf` consumes self. We cannot use that because at the call site we cannot consume the temp dir. To get around this we do a little dance of getting a reference to a `Path` and then calling `to_path_buf()` on it. We end up with code that looks kind of funky: self.cache_dire.path().to_path_buf() That's the best I could come up with :)

`unwrap_or_else()` is more performant than `unwrap_or`. Found by clippy.

Clippy emits warning: warning: this `.into_iter()` call is equivalent to `.iter()` and will not move the `slice` Do as clippy suggests and use `iter()` directly.

Clippy emits error: error: written amount is not handled. Use `Write::write_all` instead Use `write_all` as clippy suggests since we do not use the return result.

Clippy emits warning: warning: identical conversion Remove the call to `into_iter()`, as suggested by clippy, and use `iter()`.

Clippy emits error: error: use of `expect` followed by a function call Do as suggested by clippy and use `unwrap_or_else()` coupled with `panic!` instead of calling `format!` as an argument to `expect()`.

Clippy emits warning: warning: long literal lacking separators Add separators as suggested by clippy to assist reading.

We use a couple of strict float comparisons to test. In each case the strict comparison is ok. Add a lint ignore and also comment each site that does strict float comparison.

We use the `black_box` function in a bunch of places, at times the function argument returns unit, this is to be expected since the argument is not used for its return value. Instruct clippy to set the `unit_arg` lint to allow.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(storage-proofs): fix clippy warnings #1147

refactor(storage-proofs): fix clippy warnings #1147

Commits on Jun 18, 2020