Eth JSON-RPC: support passing uint64 in JSON-RPC arguments for EthUint64 #9961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychiaoli18
force-pushed
the
fix/EthUint64-args
branch
from
5e65c6c
to
01d4693
Compare
ychiaoli18
force-pushed
the
fix/EthUint64-args
branch
from
a0f7df6
to
57bf1c7
Compare
raulk
reviewed
Feb 10, 2023
There was a problem hiding this comment.
Could you please add a test for eth_feeHistory here? We should be testing all styles of arguments.
Plus points if you investigate exactly what MetaMask, ethers.js, web3.js, and other tools use and add test cases for those, since we know this method is a bit of a snowflake.
magik6k
approved these changes
Feb 10, 2023
magik6k
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes filecoin-project/ref-fvm#1365
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps