Account abstraction #9831
Merged
Account abstraction #9831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Dec 11, 2022
| @@ -521,7 +521,7 @@ func (filec *FilecoinEC) checkBlockMessages(ctx context.Context, b *types.FullBl | |||
| return xerrors.Errorf("failed to get actor: %w", err) | |||
| } | |||
|
|
|||
| if !isValidForSending(act) { | |||
| if !IsValidForSending(act) { | |||
There was a problem hiding this comment.
Do we need to put this behind a version check? I guess the actor couldn't exist on-chain... but I wanted to double check.
There was a problem hiding this comment.
Yeah, we shouldn't need to as written.
chain/consensus/filcns/filecoin.go
Outdated
| if builtin.IsAccountActor(act.Code) { | ||
| return true | ||
| } | ||
|
|
||
| // HACK: Allow Eth embryos to send messages | ||
| if !builtin.IsEmbryo(act.Code) || act.Address == nil || act.Address.Protocol() != address.Delegated { | ||
| if !builtin.IsEmbryo(act.Code) || act.Address == nil || act.Address.Protocol() != address.Delegated || act.Nonce != 0 { |
There was a problem hiding this comment.
Also ethereum accounts? Or are we including that in IsAccountActor?
There was a problem hiding this comment.
Eth Accounts didn't exist yet -- adding now.
This was referenced Dec 13, 2022
arajasek
force-pushed
the
asr/account-abstraction
branch
from
eccabaa
to
90288ef
Compare
arajasek
force-pushed
the
asr/account-abstraction
branch
from
90288ef
to
a3809e1
Compare
arajasek
force-pushed
the
asr/account-abstraction
branch
from
a3809e1
to
54cb97a
Compare
Stebalien
approved these changes
Dec 16, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows sends from Embryos if and only if their delegated addresses are valid Ethereum Account addresses.