feat: cli: gas estimation tooling #9654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
force-pushed
the
gstuart/gas-estimation-tooling
branch
from
3c50d27 to
790e219
Compare
geoff-vball
force-pushed
the
gstuart/gas-estimation-tooling
branch
from
790e219 to
867f4ee
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
geoff-vball
force-pushed
the
gstuart/gas-estimation-tooling
branch
4 times, most recently
from
cc0682e to
ae6a3cf
Compare
geoff-vball
force-pushed
the
gstuart/gas-estimation-tooling
branch
from
ae6a3cf to
62fedfb
Compare
arajasek
reviewed
Nov 16, 2022
| @@ -69,6 +69,10 @@ var DrandConfigs = map[DrandEnum]dtypes.DrandConfig{ | |||
| ChainInfoJSON: `{"public_key":"8cda589f88914aa728fd183f383980b35789ce81b274e5daee1f338b77d02566ef4d3fb0098af1f844f10f9c803c1827","period":25,"genesis_time":1595348225,"hash":"e73b7dc3c4f6a236378220c0dd6aa110eb16eed26c11259606e07ee122838d4f","groupHash":"567d4785122a5a3e75a9bc9911d7ea807dd85ff76b78dc4ff06b075712898607"}`, | |||
| }, | |||
| DrandIncentinet: { | |||
| Servers: []string{ | |||
There was a problem hiding this comment.
Due to some weird initialization stuff I do, the old beacon needs that. No idea why, that was the quickest fix for hacky code.
There was a problem hiding this comment.
@geoff-vball Can you check if this is needed as part of this PR?
There was a problem hiding this comment.
It is needed in the sense that if I remove it everything breaks. Whether or not its the best way to do things another question
arajasek
reviewed
Nov 16, 2022
geoff-vball
force-pushed
the
gstuart/gas-estimation-tooling
branch
2 times, most recently
from
fdf0bb1 to
e5c4aa7
Compare
|
Example output:
|
geoff-vball
force-pushed
the
gstuart/gas-estimation-tooling
branch
from
e5c4aa7 to
4654350
Compare
arajasek
reviewed
Nov 17, 2022
| @@ -69,6 +69,10 @@ var DrandConfigs = map[DrandEnum]dtypes.DrandConfig{ | |||
| ChainInfoJSON: `{"public_key":"8cda589f88914aa728fd183f383980b35789ce81b274e5daee1f338b77d02566ef4d3fb0098af1f844f10f9c803c1827","period":25,"genesis_time":1595348225,"hash":"e73b7dc3c4f6a236378220c0dd6aa110eb16eed26c11259606e07ee122838d4f","groupHash":"567d4785122a5a3e75a9bc9911d7ea807dd85ff76b78dc4ff06b075712898607"}`, | |||
| }, | |||
| DrandIncentinet: { | |||
| Servers: []string{ | |||
There was a problem hiding this comment.
@geoff-vball Can you check if this is needed as part of this PR?
| if ts == nil { | ||
| return xerrors.Errorf("could not find message within the last %d epochs", lookbackLimit) | ||
| } | ||
| executionTs, err := cs.GetTipsetByHeight(ctx, ts.Height()-2, ts, true) |
There was a problem hiding this comment.
That is probably question for me, no idea, that is what worked at the time :P
|
@geoff-vball Please add a description of the stmgr::Call refactor to the description. |
geoff-vball
force-pushed
the
gstuart/gas-estimation-tooling
branch
6 times, most recently
from
8c7dcb4 to
a31b0f2
Compare
geoff-vball
force-pushed
the
gstuart/gas-estimation-tooling
branch
from
a31b0f2 to
9603500
Compare
arajasek
approved these changes
Nov 22, 2022
29 tasks
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
The idea here is to have a lotus-shed command that can take a message that has already landed on chain, and replay that message using a migrated state and new actors. This will allow us to more easily test the gas changes caused by new actors.
I also add a
skip-pre-migrationflag to themigrate-nv17shed command so that it can be used to migrate the state only once, for use with the newtrace-gasfunction.The function
CallAtStateAndVersionis taken from @Kubuxu's branchfeat/migrate-and-runI've refactored
CallandCallWithGasto a common function. The main difference between these calls are thatCallexecutes the message in the given tipset, and doesn't care about gas costs.CallWithGasexecuted the message ON TOP of the given tipset (in the next epoch) and therefore has to compute the tipset state.The only functional change that should be present is that
Callused returnErrExpensiveForkonly if the parent of a specified contained an expensive fork. Now it will returnErrExpensiveForkif any epoch from the parent to the tipset itself (including nil tipsets) contain an expensive fork. This matches what was done inCallWithGasand was just changed for simplicity.Callwill also no long default to 0 base fee.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps