Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): eth/id address conversion #9511

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

Stebalien
Copy link
Member

Specifically, check if we have the expected prefix and return a sane error.

@Stebalien Stebalien requested a review from a team as a code owner October 18, 2022 19:09
Specifically, check if we have the expected prefix and return a sane error.
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of the error saying "id-in-eth" (we've been using the term "masked ID address"), but will revisit anyway with f4 addressing.

@raulk raulk merged commit b649e23 into experimental/fvm-m2 Oct 19, 2022
@raulk raulk deleted the fix/eth-id-conversion branch October 19, 2022 12:52
vyzo pushed a commit that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants