Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cli: Add commands for listing allocations and removing expired allocations #9468

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Oct 11, 2022

Related Issues

Closes #9272

Proposed Changes

Additional Info

This should get some testing from TSEs before merging.

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@geoff-vball geoff-vball requested a review from a team as a code owner October 11, 2022 20:44
@geoff-vball geoff-vball force-pushed the gstuart/FIP-0045-cli branch 3 times, most recently from 411fa07 to fc1b98b Compare October 12, 2022 18:27
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. It's gonna be hard to test on a 30-second network (eg. butterflynet), so I would suggest testing on a devnet.

I'm also happy to land this without manual exercise.

cli/filplus.go Outdated Show resolved Hide resolved
geoff-vball and others added 2 commits October 13, 2022 13:07
@jennijuju jennijuju merged commit 39557de into release/v1.18.0 Oct 13, 2022
@jennijuju jennijuju deleted the gstuart/FIP-0045-cli branch October 13, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants