Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rpc: readd rpc.discover aliases; lotus-gateway openrpc #8738

Merged
merged 2 commits into from
May 27, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented May 27, 2022

Related Issues

Fixes #8556

Proposed Changes

Re-add rpc.discover alias to the Discover method. We definitely used to have it, but it got lost somehow in one of the many api refactors.

Also add openrpc support to lotus-gateway

@magik6k magik6k requested a review from a team as a code owner May 27, 2022 11:43
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #8738 (b0f7faa) into master (7836e20) will increase coverage by 0.07%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8738      +/-   ##
==========================================
+ Coverage   40.84%   40.91%   +0.07%     
==========================================
  Files         692      692              
  Lines       76177    76188      +11     
==========================================
+ Hits        31112    31174      +62     
+ Misses      39688    39654      -34     
+ Partials     5377     5360      -17     
Impacted Files Coverage Δ
gateway/node.go 44.71% <0.00%> (-0.44%) ⬇️
build/openrpc.go 56.25% <60.00%> (+0.69%) ⬆️
cmd/lotus-worker/sealworker/rpc.go 37.25% <100.00%> (+1.25%) ⬆️
gateway/handler.go 91.66% <100.00%> (+0.36%) ⬆️
node/rpc.go 28.57% <100.00%> (+1.15%) ⬆️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
storage/wdpost_sched.go 77.45% <0.00%> (-3.93%) ⬇️
extern/sector-storage/sched_worker.go 78.23% <0.00%> (-1.18%) ⬇️
extern/sector-storage/stores/remote.go 57.76% <0.00%> (-0.44%) ⬇️
... and 18 more

@arajasek arajasek enabled auto-merge May 27, 2022 15:16
@arajasek arajasek merged commit 44d415a into master May 27, 2022
@arajasek arajasek deleted the fix/openrpc-aliases branch May 27, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpc.discover doesn't work properly
2 participants