feat: api: Make ClientCalcCommP multithreaded #8276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
reviewed
Mar 10, 2022
ZenGround0
reviewed
Mar 10, 2022
| @@ -1295,16 +1278,20 @@ func (a *API) ClientCalcCommP(ctx context.Context, inpath string) (*api.CommPRet | |||
| return nil, xerrors.Errorf("seek to start: %w", err) | |||
| } | |||
|
|
|||
| pieceReader, pieceSize := padreader.New(rdr, uint64(stat.Size())) | |||
| commP, err := ffiwrapper.GeneratePieceCIDFromFile(arbitraryProofType, pieceReader, pieceSize) | |||
There was a problem hiding this comment.
This kind of makes sense but I don't understand why this ffiwrapper thing exists and was called in the first place if the commp writer thing could just do a direct sum over the piece bytes in the first place.
There was a problem hiding this comment.
The writer thing is relatively recent, and this API existed for quite some time before.
There was a problem hiding this comment.
(the writer also calls FFI, it just does that from multiple threads for smaller chunks, then creates the top tree from them)
ZenGround0
approved these changes
Mar 10, 2022
Codecov Report
@@ Coverage Diff @@
## master #8276 +/- ##
=======================================
Coverage 40.51% 40.51%
=======================================
Files 675 675
Lines 73527 73526 -1
=======================================
+ Hits 29788 29790 +2
+ Misses 38515 38510 -5
- Partials 5224 5226 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Make
ClientCalcCommPa lot fasterAdditional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps