Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update to graphsync v0.13.0 with 2.0 protocol #8273

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

hannahhoward
Copy link
Contributor

Proposed Changes

This PR updates go-graphsync and go-data-transfer. From the standpoint of Lotus, it's very small. However, the 0.13.0 version of go-graphsync includes significant changes. You can see them in go-graphsync's CHANGELOG here: https://github.com/ipfs/go-graphsync/blob/main/CHANGELOG.md

The only changes in Lotus other than go.mod updates are that GraphSync has a new ID type for Requests -- they are now UUIDs. I made a small change to the MinerTransferDiagnostics API, which I'm pretty sure no one but me knows about or uses anyway :)

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • [x ] All commits have a clear commit message.
  • [x ] The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • [x ] This PR has tests for new functionality or change in behaviour
  • [x ] If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • [x ] CI is green

@hannahhoward hannahhoward requested a review from a team as a code owner March 9, 2022 17:57
@jennijuju jennijuju added this to the v1.15.1 milestone Mar 9, 2022
@jennijuju jennijuju added the P1 P1: Must be resolved label Mar 9, 2022
@hannahhoward hannahhoward force-pushed the feat/graphsync-20-protocol-update branch from 55f4279 to 4b3901d Compare March 9, 2022 17:58
@hannahhoward hannahhoward force-pushed the feat/graphsync-20-protocol-update branch from 4b3901d to 49742f8 Compare March 9, 2022 18:06
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #8273 (49742f8) into master (c192637) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8273      +/-   ##
==========================================
- Coverage   40.51%   40.49%   -0.02%     
==========================================
  Files         675      675              
  Lines       73527    73527              
==========================================
- Hits        29788    29776      -12     
- Misses      38515    38530      +15     
+ Partials     5224     5221       -3     
Impacted Files Coverage Δ
api/types.go 52.77% <ø> (ø)
node/impl/storminer.go 21.80% <0.00%> (+0.31%) ⬆️
storage/wdpost_sched.go 75.49% <0.00%> (-5.89%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-4.42%) ⬇️
chain/stmgr/call.go 71.51% <0.00%> (-3.64%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/store/store.go 63.00% <0.00%> (-1.17%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-0.95%) ⬇️
extern/sector-storage/stores/local.go 59.16% <0.00%> (-0.84%) ⬇️
chain/consensus/filcns/filecoin.go 52.17% <0.00%> (-0.44%) ⬇️
... and 8 more

@magik6k magik6k merged commit 326a9b6 into master Mar 10, 2022
@magik6k magik6k deleted the feat/graphsync-20-protocol-update branch March 10, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 P1: Must be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants