Implement FIP-0031 #8209
Closed
Implement FIP-0031 #8209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
resolves #8061 |
|
The test failures are because they try to run with the latest network version (set to v16 in this PR), which is currently unsupported by the FVM and the actors. We could:
|
|
Closes #8064 |
|
after feat/fvm is merged into master (tmr) then that branch would be closed. |
magik6k
reviewed
Mar 28, 2022
| @@ -55,6 +55,7 @@ require ( | |||
| github.com/filecoin-project/specs-actors/v5 v5.0.4 | |||
| github.com/filecoin-project/specs-actors/v6 v6.0.1 | |||
| github.com/filecoin-project/specs-actors/v7 v7.0.0 | |||
| github.com/filecoin-project/specs-actors/v8 v8.0.0-20220301040630-7465555c2e22 | |||
There was a problem hiding this comment.
Probably want a tag for master
| @@ -63,6 +64,7 @@ func NewActorRegistry() *vm.ActorRegistry { | |||
| inv.Register(vm.ActorsVersionPredicate(actors.Version5), exported5.BuiltinActors()...) | |||
| inv.Register(vm.ActorsVersionPredicate(actors.Version6), exported6.BuiltinActors()...) | |||
| inv.Register(vm.ActorsVersionPredicate(actors.Version7), exported7.BuiltinActors()...) | |||
| inv.Register(vm.ActorsVersionPredicate(actors.Version8), exported8.BuiltinActors()...) | |||
There was a problem hiding this comment.
Do we want to register those?
| @@ -133,6 +134,8 @@ func newAccountActor(ver actors.Version) *types.Actor { | |||
| code = builtin6.AccountActorCodeID | |||
| case actors.Version7: | |||
| code = builtin7.AccountActorCodeID | |||
| case actors.Version8: | |||
| code = builtin8.AccountActorCodeID | |||
There was a problem hiding this comment.
We'll need to set those code CIDs to real code CIDs
|
Superseded by #8429. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge strategy: Land #8293 in master, then land this in the appropriate branch (see @jennijuju note below).
This PR implements FIP-0031. The key changes are:
Fixes #8117.
Fixes #8061.