Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing: add flag usage #8190

Merged
merged 2 commits into from
Feb 26, 2022
Merged

fix: sealing: add flag usage #8190

merged 2 commits into from
Feb 26, 2022

Conversation

jennijuju
Copy link
Member

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@jennijuju jennijuju requested a review from a team as a code owner February 25, 2022 15:52
@arajasek
Copy link
Contributor

needs make gen

@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #8190 (865c7e5) into master (64b13af) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8190      +/-   ##
==========================================
- Coverage   39.82%   39.80%   -0.03%     
==========================================
  Files         666      666              
  Lines       72754    72754              
==========================================
- Hits        28974    28957      -17     
- Misses      38737    38756      +19     
+ Partials     5043     5041       -2     
Impacted Files Coverage Δ
cmd/lotus-miner/sectors.go 13.98% <ø> (ø)
markets/loggers/loggers.go 88.88% <0.00%> (-11.12%) ⬇️
extern/sector-storage/worker_tracked.go 79.46% <0.00%> (-7.15%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
blockstore/buffered.go 34.44% <0.00%> (-2.23%) ⬇️
chain/store/store.go 63.00% <0.00%> (-1.84%) ⬇️
extern/storage-sealing/fsm.go 57.49% <0.00%> (-1.40%) ⬇️
paychmgr/simple.go 79.32% <0.00%> (-0.93%) ⬇️
extern/sector-storage/sched.go 83.95% <0.00%> (-0.83%) ⬇️
chain/sync_manager.go 66.77% <0.00%> (-0.63%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b13af...865c7e5. Read the comment docs.

@jennijuju jennijuju merged commit d495c3c into master Feb 26, 2022
@jennijuju jennijuju deleted the jen/flagfix branch February 26, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants