Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily disable reification #8132

Merged
merged 2 commits into from
Feb 17, 2022
Merged

temporarily disable reification #8132

merged 2 commits into from
Feb 17, 2022

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Feb 17, 2022

big reifications can use a lot of memory during sync apparently.

Temporarily disabling reification until I can sort out the memory usage during sync.

big reifications can use a lot of memory during sync apparently.
@vyzo vyzo requested a review from magik6k February 17, 2022 17:58
@vyzo vyzo requested a review from a team as a code owner February 17, 2022 17:58
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #8132 (899a65a) into master (72021b3) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8132      +/-   ##
==========================================
- Coverage   39.36%   39.33%   -0.04%     
==========================================
  Files         666      666              
  Lines       72464    72466       +2     
==========================================
- Hits        28527    28501      -26     
- Misses      39003    39023      +20     
- Partials     4934     4942       +8     
Impacted Files Coverage Δ
blockstore/splitstore/splitstore_reify.go 50.86% <0.00%> (-0.90%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
chain/stmgr/tracers.go 84.21% <0.00%> (-5.27%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
miner/warmup.go 70.83% <0.00%> (-4.17%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
miner/miner.go 53.11% <0.00%> (-3.28%) ⬇️
storage/wdpost_sched.go 79.41% <0.00%> (-1.97%) ⬇️
chain/store/store.go 63.66% <0.00%> (-1.84%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-1.29%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72021b3...899a65a. Read the comment docs.

@magik6k magik6k merged commit 81d2fd6 into master Feb 17, 2022
@magik6k magik6k deleted the fix/disable-reify branch February 17, 2022 18:30
@magik6k magik6k added this to the v1.15.0 milestone Feb 17, 2022
@magik6k
Copy link
Contributor

magik6k commented Feb 17, 2022

(backport in case we don't get anything better soon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants