Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't fail reification on missing references #8128

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Feb 17, 2022

some of these are ok (eg missing receipts in a block) and this could spam the log repeatedly, so use incomplete walk.

@vyzo vyzo requested a review from magik6k February 17, 2022 10:54
@vyzo vyzo requested a review from a team as a code owner February 17, 2022 10:54
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #8128 (74556ed) into master (3622483) will decrease coverage by 0.03%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8128      +/-   ##
==========================================
- Coverage   39.38%   39.34%   -0.04%     
==========================================
  Files         666      666              
  Lines       72462    72466       +4     
==========================================
- Hits        28541    28514      -27     
- Misses      38999    39014      +15     
- Partials     4922     4938      +16     
Impacted Files Coverage Δ
blockstore/splitstore/splitstore_reify.go 51.75% <25.00%> (-1.89%) ⬇️
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-11.77%) ⬇️
chain/stmgr/call.go 71.51% <0.00%> (-3.64%) ⬇️
miner/miner.go 54.75% <0.00%> (-1.97%) ⬇️
chain/events/events_called.go 83.90% <0.00%> (-1.96%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-1.42%) ⬇️
chain/stmgr/searchwait.go 67.30% <0.00%> (-1.29%) ⬇️
chain/gen/gen.go 68.19% <0.00%> (-1.23%) ⬇️
extern/storage-sealing/fsm.go 56.44% <0.00%> (-1.05%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3622483...74556ed. Read the comment docs.

@magik6k magik6k merged commit 93bc3af into master Feb 17, 2022
@magik6k magik6k deleted the fix/splitstore-reify-incomplete branch February 17, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants