test: cli: unit tests for sync related commands #8080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deals_retry_deal_no_funds_test.go:TestDealsRetryLackOfFunds seems to be flaky, sometimes it passes and sometimes it doesn't. The first suspect for me was time.Sleep(), which I replaced with waiting until a deal state where you can restart is reached.
This reverts commit baee4a1.
Codecov Report
@@ Coverage Diff @@
## master #8080 +/- ##
==========================================
+ Coverage 39.91% 39.94% +0.02%
==========================================
Files 666 666
Lines 72554 72556 +2
==========================================
+ Hits 28963 28985 +22
+ Misses 38553 38503 -50
- Partials 5038 5068 +30
Continue to review full report at Codecov.
|
magik6k
approved these changes
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR contains unit tests for CLI commands from the
synccategory e.g.lotus sync *.Everything is covered except
lotus sync waitsince it's tricky to mock.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps